Skip to content

test(config): run tests in dedicated netns #40150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2025
Merged

test(config): run tests in dedicated netns #40150

merged 1 commit into from
Jul 21, 2025

Conversation

AritraDey-Dev
Copy link
Member

Fixes #22433

Fix privileged test issue observed locally .
Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #22433

Fixed an issue where privileged tests failed locally

@AritraDey-Dev AritraDey-Dev requested a review from a team as a code owner June 21, 2025 20:32
@AritraDey-Dev AritraDey-Dev requested a review from ti-mo June 21, 2025 20:32
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 21, 2025
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jun 21, 2025
ti-mo
ti-mo requested changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@ti-mo ti-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use pkg/testutils/netns for this, no need for the manual netns plumbing.

Simply:

ns := netns.NewNetNS(t)
ns.Do(func() {
// test code
})

@AritraDey-Dev AritraDey-Dev force-pushed the fix/ci-test-privilleged-error branch from e4d0c07 to b34e4d7 Compare June 28, 2025 16:31
@AritraDey-Dev
Copy link
Member Author

Please use pkg/testutils/netns for this, no need for the manual netns plumbing.

updated!

@AritraDey-Dev AritraDey-Dev requested a review from ti-mo June 28, 2025 17:41
ti-mo
ti-mo requested changes Jul 1, 2025
View reviewed changes
@ti-mo ti-mo added the release-note/ci This PR makes changes to the CI. label Jul 1, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 1, 2025
@AritraDey-Dev AritraDey-Dev force-pushed the fix/ci-test-privilleged-error branch from b34e4d7 to b4d02a1 Compare July 4, 2025 02:31
@AritraDey-Dev AritraDey-Dev requested a review from ti-mo July 4, 2025 02:35
ti-mo
ti-mo requested changes Jul 7, 2025
View reviewed changes
@AritraDey-Dev AritraDey-Dev requested a review from a team as a code owner July 9, 2025 23:56
@joestringer joestringer added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Jul 10, 2025
ti-mo
ti-mo approved these changes Jul 11, 2025
View reviewed changes
@ti-mo
Copy link
Contributor

ti-mo commented Jul 11, 2025

Note: names of privileged tests now need to be prefixed with TestPrivileged.

@AritraDey-Dev AritraDey-Dev force-pushed the fix/ci-test-privilleged-error branch 2 times, most recently from b43038a to d6c5db8 Compare July 15, 2025 12:26
@AritraDey-Dev
Copy link
Member Author

/test

christarazi
christarazi approved these changes Jul 16, 2025
View reviewed changes
@AritraDey-Dev AritraDey-Dev force-pushed the fix/ci-test-privilleged-error branch 2 times, most recently from 9175c8e to 7f52245 Compare July 16, 2025 01:18
@AritraDey-Dev
test(config): run tests in dedicated netns
0e8423e 
Fixes cilium#22433

Signed-off-by: Aritra Dey <adey01027@gmail.com>
@AritraDey-Dev AritraDey-Dev force-pushed the fix/ci-test-privilleged-error branch from 7f52245 to 0e8423e Compare July 16, 2025 01:46
@AritraDey-Dev
Copy link
Member Author

/test

@joestringer joestringer removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Jul 17, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 17, 2025
joestringer
joestringer reviewed Jul 17, 2025
View reviewed changes
@joestringer joestringer added dont-merge/discussion A discussion is ongoing and should be resolved before merging, regardless of reviews & tests status. and removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. dont-merge/discussion A discussion is ongoing and should be resolved before merging, regardless of reviews & tests status. labels Jul 17, 2025
@joestringer joestringer added this pull request to the merge queue Jul 21, 2025
Merged via the queue into cilium:main with commit 5c60758 Jul 21, 2025
68 checks passed
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Jul 21, 2025
@AritraDey-Dev AritraDey-Dev deleted the fix/ci-test-privilleged-error branch July 24, 2025 14:04
@jingyuanliang
Copy link
Contributor

Can we cherry-pick this into v1.18?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer left review comments

@ti-mo ti-mo ti-mo approved these changes

@christarazi christarazi christarazi approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: go test ./pkg/datapath/loader fails: Link does not exist
5 participants
@AritraDey-Dev @ti-mo @jingyuanliang @joestringer @christarazi