Skip to content

connectivity: Export detailed failure messages in junit report #40035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

connectivity: Export detailed failure messages in junit report #40035

merged 1 commit into from
Jun 17, 2025

Conversation

mathpl
Copy link
Contributor

@mathpl mathpl commented Jun 13, 2025 •
edited
Loading

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Building on top of #39866, also include the failure message in the Junit test report.

Fixes: #issue-number

Test failure message included in Junit report of the connectivity tests.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 13, 2025
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Jun 13, 2025
@mathpl
Copy link
Contributor Author

mathpl commented Jun 16, 2025

/test

@mathpl
Copy link
Contributor Author

mathpl commented Jun 16, 2025

/ci-ingress

@mathpl mathpl force-pushed the test-error-message-in-junit branch from 1cfb4f9 to 0b2e6b9 Compare June 16, 2025 20:30
@mathpl
connectivity: Export detailed failure messages in junit report
b07a2a7 
Signed-off-by: Mathieu Payeur Levallois <mpl@mpl.sh>
@mathpl mathpl force-pushed the test-error-message-in-junit branch from 0b2e6b9 to b07a2a7 Compare June 16, 2025 20:31
@mathpl
Copy link
Contributor Author

mathpl commented Jun 16, 2025

/test

@mathpl
Copy link
Contributor Author

mathpl commented Jun 16, 2025

/ci-gateway-api

1 similar comment
@mathpl
Copy link
Contributor Author

mathpl commented Jun 17, 2025

/ci-gateway-api

@mathpl
Copy link
Contributor Author

mathpl commented Jun 17, 2025

/ci-eks

@mathpl
Copy link
Contributor Author

mathpl commented Jun 17, 2025

/scale-clustermesh

@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Jun 17, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 17, 2025
@aanm aanm marked this pull request as ready for review June 17, 2025 09:23
@aanm aanm requested a review from a team as a code owner June 17, 2025 09:23
@aanm aanm requested a review from christarazi June 17, 2025 09:23
@aanm aanm enabled auto-merge June 17, 2025 09:23
@mathpl mathpl added needs-backport/1.15 needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch and removed needs-backport/1.15 needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Jun 17, 2025
@aanm aanm added this pull request to the merge queue Jun 17, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 17, 2025
Merged via the queue into cilium:main with commit 1ec7050 Jun 17, 2025
73 checks passed
@mathpl mathpl mentioned this pull request Jun 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathpl @christarazi @aanm