Skip to content

Conversation

nebril
Copy link
Member

@nebril nebril commented Jun 12, 2025

This change allows Cilium CLI to detect OpenShift cluster kind. This will be helpful especially in sysdump if we want to gather OpenShift specific data.

@nebril nebril requested a review from a team as a code owner June 12, 2025 14:23
@nebril nebril requested a review from youngnick June 12, 2025 14:23
@nebril nebril added release-note/misc This PR makes changes that have no direct user impact. affects/v1.17 This issue affects v1.17 branch labels Jun 12, 2025
@nebril
Copy link
Member Author

nebril commented Jun 12, 2025

/test

@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Jun 12, 2025
This change allows Cilium CLI to detect OpenShift cluster kind. This
will be helpful especially in sysdump if we want to gather OpenShift
specific data.

Signed-off-by: Maciej Kwiek <mkwiek@cisco.com>
@nebril nebril force-pushed the pr/nebril/openshift-detection-cli branch from 31b8f73 to 9751364 Compare June 13, 2025 07:52
@nebril
Copy link
Member Author

nebril commented Jun 13, 2025

/test

Copy link
Contributor

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 13, 2025
@nebril nebril enabled auto-merge June 13, 2025 12:10
@nebril nebril added this pull request to the merge queue Jun 13, 2025
Merged via the queue into main with commit 8030e70 Jun 13, 2025
238 of 242 checks passed
@nebril nebril deleted the pr/nebril/openshift-detection-cli branch June 13, 2025 20:11
@nebril nebril removed the affects/v1.17 This issue affects v1.17 branch label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants