cli: Enable tolerations flag for all connectivity tests
#40072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christarazi
reviewed
Jun 16, 2025
HadrienPatte
commented
Jun 16, 2025
In clusters where all nodes have NoSchedule taints, the connectivity tests pods currently stay pending, leading the tests to time out. By making the `tolerations` flag available to the `cilium connectivity test` command, we allow setting tolerations to tolerate those taints and get the tests pods to schedule on nodes. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
ef8cc8c to
234d3dc
Compare
|
/test |
christarazi
approved these changes
Jun 17, 2025
derailed
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the cilium CLI's performance connectivity check (
cilium connectivity perf) has a--tolerationsflag allowing to set tolerations on the test pods. This feature would also be useful for the connectivity tests (cilium connectivity test). This PR moves this flag from being aperfonly flag to being a globalconnectivityflag so that it can be used with both commands.Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Fixes: #issue-number