Skip to content

auto-approve: add repository as part command #40050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

auto-approve: add repository as part command #40050

merged 1 commit into from
Jun 16, 2025

Conversation

aanm
Copy link
Member

@aanm aanm commented Jun 16, 2025

If the command doesn't have the repository as part of the command, then gh will try to derive it from the .git directory. Since this directory doesn't exist, the command fails.

Fixes: 2b24f33 (".github/workflows: remove reviewers if ciliumbot approved PR")

If the command doesn't have the repository as part of the command, then
gh will try to derive it from the .git directory. Since this directory
doesn't exist, the command fails.

Fixes: 2b24f33 (".github/workflows: remove reviewers if ciliumbot approved PR")
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm requested a review from a team as a code owner June 16, 2025 07:52
@aanm aanm requested a review from joestringer June 16, 2025 07:52
@aanm aanm added release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.15 needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Jun 16, 2025
@aanm
Copy link
Member Author

aanm commented Jun 16, 2025

/test

@aanm aanm enabled auto-merge June 16, 2025 07:52
@aanm aanm added this pull request to the merge queue Jun 16, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 16, 2025
Merged via the queue into main with commit 1a2faea Jun 16, 2025
72 of 74 checks passed
@aanm aanm deleted the pr/fix-auto-approve branch June 16, 2025 15:56
@joamaki joamaki mentioned this pull request Jun 17, 2025
4 tasks
@joamaki joamaki added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 labels Jun 17, 2025
@joamaki joamaki mentioned this pull request Jun 17, 2025
4 tasks
@joamaki joamaki added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Jun 17, 2025
@joamaki joamaki mentioned this pull request Jun 17, 2025
5 tasks
@joamaki joamaki added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Jun 17, 2025
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. labels Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants