Skip to content

Conversation

aanm
Copy link
Member

@aanm aanm commented Jul 13, 2016

Signed-off-by: André Martins andre@cilium.io

@aanm aanm added the wip label Jul 13, 2016
@aanm aanm force-pushed the creating-dockerfile branch 2 times, most recently from 6674d84 to 54bf693 Compare July 25, 2016 18:16
@aanm aanm added kind/enhancement This would improve or streamline existing functionality. pending-review and removed wip labels Jul 25, 2016
@aanm
Copy link
Member Author

aanm commented Jul 25, 2016

@tgraf Should I add something else to the example?

@aanm
Copy link
Member Author

aanm commented Jul 25, 2016

Also I'm not deleting unnecessary stuff from clang

@aanm aanm force-pushed the creating-dockerfile branch from 54bf693 to 78e08bc Compare July 25, 2016 19:07
@tgraf
Copy link
Member

tgraf commented Jul 25, 2016

Looks great!

Acked-by: Thomas Graf <thomas@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the creating-dockerfile branch from 78e08bc to 6e69c27 Compare July 25, 2016 21:14
@aanm aanm merged commit 8a0e02a into master Jul 25, 2016
@aanm aanm deleted the creating-dockerfile branch July 25, 2016 23:52
@dctrwatson dctrwatson mentioned this pull request Jun 2, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement This would improve or streamline existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants