-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Open
Labels
good-first-issueGood starting point for new developers, which requires minimal understanding of Cilium.Good starting point for new developers, which requires minimal understanding of Cilium.kind/cfpCilium Feature ProposalCilium Feature Proposalkind/featureThis introduces new functionality.This introduces new functionality.
Description
Running staticcheck on Cilium gives the following list:
daemon/cmd/status.go:279:29: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0: The rule Title uses for word boundaries does not handle Unicode punctuation properly. Use golang.org/x/text/cases instead. (SA1019)
daemon/cmd/status.go:289:37: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0: The rule Title uses for word boundaries does not handle Unicode punctuation properly. Use golang.org/x/text/cases instead. (SA1019)
operator/pkg/gateway-api/gateway_status.go:63:31: gatewayv1.GatewayReasonListenersNotReady is deprecated: Ready is reserved for future use (SA1019)
operator/pkg/gateway-api/gateway_status.go:77:31: gatewayv1.GatewayReasonReady is deprecated: Ready is reserved for future use (SA1019)
operator/pkg/gateway-api/gateway_status.go:86:31: gatewayv1.GatewayReasonListenersNotReady is deprecated: Ready is reserved for future use (SA1019)
operator/pkg/model/translation/gateway-api/translator_fixture_test.go:29:2: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (SA1019)
pkg/aws/ec2/ec2.go:91:2: cfg.EndpointResolver is deprecated: See Config.EndpointResolverWithOptions (SA1019)
pkg/aws/ec2/ec2.go:91:25: aws.EndpointResolverFunc is deprecated: See EndpointResolverWithOptionsFunc (SA1019)
pkg/aws/eni/limits/limits_test.go:13:2: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (SA1019)
pkg/azure/api/api.go:15:2: "github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2021-08-01/compute" is deprecated: Please note, this package has been deprecated. A replacement package is available [github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute](https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute). We strongly encourage you to upgrade to continue receiving updates. See [Migration Guide](https://aka.ms/azsdk/golang/t2/migration) for guidance on upgrading. Refer to our [deprecation policy](https://azure.github.io/azure-sdk/policies_support.html) for more details. (SA1019)
pkg/azure/api/api.go:16:2: "github.com/Azure/azure-sdk-for-go/services/network/mgmt/2021-08-01/network" is deprecated: Please note, this package has been deprecated. A replacement package is available [github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/network/armnetwork](https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/network/armnetwork). We strongly encourage you to upgrade to continue receiving updates. See [Migration Guide](https://aka.ms/azsdk/golang/t2/migration) for guidance on upgrading. Refer to our [deprecation policy](https://azure.github.io/azure-sdk/policies_support.html) for more details. (SA1019)
pkg/bgpv1/agent/controller_test.go:13:2: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (SA1019)
pkg/bgpv1/gobgp/peer.go:111:5: n.Neighbor is deprecated: field kept for backward compatibility. (SA1019)
pkg/bgpv1/gobgp/peer.go:116:35: n.Neighbor is deprecated: field kept for backward compatibility. (SA1019)
pkg/bgpv1/gobgp/peer.go:122:22: n.Neighbor is deprecated: field kept for backward compatibility. (SA1019)
pkg/bgpv1/gobgp/peer.go:125:60: n.Neighbor is deprecated: field kept for backward compatibility. (SA1019)
pkg/bgpv1/gobgp/peer.go:130:46: n.Neighbor is deprecated: field kept for backward compatibility. (SA1019)
pkg/bgpv1/gobgp/peer.go:142:5: n.Neighbor is deprecated: field kept for backward compatibility. (SA1019)
pkg/bgpv1/gobgp/peer.go:143:41: n.Neighbor is deprecated: field kept for backward compatibility. (SA1019)
pkg/bgpv1/gobgp/peer.go:143:70: n.Neighbor is deprecated: field kept for backward compatibility. (SA1019)
pkg/bgpv1/gobgp/peer.go:147:32: n.Neighbor is deprecated: field kept for backward compatibility. (SA1019)
pkg/bgpv1/gobgp/peer.go:147:77: n.Neighbor is deprecated: field kept for backward compatibility. (SA1019)
pkg/bgpv1/gobgp/peer.go:147:114: n.Neighbor is deprecated: field kept for backward compatibility. (SA1019)
pkg/bgpv1/gobgp/peer.go:150:5: n.Neighbor is deprecated: field kept for backward compatibility. (SA1019)
pkg/bgpv1/gobgp/peer.go:150:42: n.Neighbor is deprecated: field kept for backward compatibility. (SA1019)
pkg/bgpv1/gobgp/peer.go:151:42: n.Neighbor is deprecated: field kept for backward compatibility. (SA1019)
pkg/bgpv1/gobgp/peer.go:151:90: n.Neighbor is deprecated: field kept for backward compatibility. (SA1019)
pkg/bgpv1/gobgp/peer.go:370:36: n.Neighbor is deprecated: field kept for backward compatibility. (SA1019)
pkg/bgpv1/gobgp/peer.go:383:68: n.Neighbor is deprecated: field kept for backward compatibility. (SA1019)
pkg/bgpv1/gobgp/peer.go:383:92: n.Neighbor is deprecated: field kept for backward compatibility. (SA1019)
pkg/bgpv1/gobgp/state_test.go:13:2: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (SA1019)
pkg/bgpv1/manager/manager_test.go:13:2: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (SA1019)
pkg/bgpv1/manager/reconciler/neighbor_test.go:13:2: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (SA1019)
pkg/bgpv1/manager/reconciler/pod_cidr_test.go:12:2: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (SA1019)
pkg/bgpv1/manager/reconciler/preflight_test.go:13:2: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (SA1019)
pkg/bgpv1/manager/reconciler/route_policy_test.go:13:2: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (SA1019)
pkg/bgpv1/manager/reconciler/service_test.go:13:2: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (SA1019)
pkg/bgpv1/test/adverts_test.go:17:2: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (SA1019)
pkg/bgpv1/test/fixtures.go:16:2: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (SA1019)
pkg/bgpv1/test/neighbor_test.go:15:2: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (SA1019)
pkg/bgpv1/types/test_fixtures.go:10:2: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (SA1019)
pkg/crypto/certloader/client_test.go:102:18: expectedCaCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/client_test.go:102:49: tlsConfig.RootCAs.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/client_test.go:174:18: expectedCaCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/client_test.go:174:49: tlsConfig.RootCAs.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/reloader_test.go:382:21: tt.expectedCaCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/reloader_test.go:382:55: caCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/reloader_test.go:459:21: tt.expectedCaCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/reloader_test.go:459:55: caCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/reloader_test.go:479:21: tt.expectedCaCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/reloader_test.go:479:55: caCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/reloader_test.go:616:21: tt.expectedCaCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/reloader_test.go:616:55: caCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/reloader_test.go:631:21: tt.expectedCaCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/reloader_test.go:631:55: caCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/reloader_test.go:660:18: expectedCaCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/reloader_test.go:660:49: caCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/reloader_test.go:675:18: expectedCaCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/reloader_test.go:675:49: caCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/server_test.go:125:18: expectedCaCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/server_test.go:125:49: tlsConfig.ClientCAs.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/server_test.go:174:18: expectedCaCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/server_test.go:174:49: tlsConfig.ClientCAs.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/watcher_test.go:46:18: expectedCaCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/watcher_test.go:46:49: caCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/watcher_test.go:85:18: expectedCaCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/watcher_test.go:85:49: caCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/watcher_test.go:112:18: expectedCaCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/watcher_test.go:112:49: caCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/watcher_test.go:150:18: expectedCaCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/watcher_test.go:150:49: caCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/watcher_test.go:186:18: expectedInitialCaCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/watcher_test.go:186:56: caCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/watcher_test.go:214:18: expectedRotatedCaCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/crypto/certloader/watcher_test.go:214:56: caCertPool.Subjects has been deprecated since Go 1.18: if s was returned by [SystemCertPool], Subjects will not include the system roots. (SA1019)
pkg/envoy/sort.go:221:8: m1.GetExactMatch is deprecated: Do not use. (SA1019)
pkg/envoy/sort.go:222:8: m2.GetExactMatch is deprecated: Do not use. (SA1019)
pkg/envoy/sort.go:230:10: m1.GetSafeRegexMatch is deprecated: Do not use. (SA1019)
pkg/envoy/sort.go:231:10: m2.GetSafeRegexMatch is deprecated: Do not use. (SA1019)
pkg/envoy/sort.go:275:7: m1.GetPrefixMatch is deprecated: Do not use. (SA1019)
pkg/envoy/sort.go:276:7: m2.GetPrefixMatch is deprecated: Do not use. (SA1019)
pkg/envoy/sort.go:284:7: m1.GetSuffixMatch is deprecated: Do not use. (SA1019)
pkg/envoy/sort.go:285:7: m2.GetSuffixMatch is deprecated: Do not use. (SA1019)
pkg/health/client/client.go:59:3: tr.Dial has been deprecated since Go 1.7: Use DialContext instead, which allows the transport to cancel dials as soon as they are no longer needed. If both are set, DialContext takes priority. (SA1019)
pkg/health/client/client.go:64:3: tr.Dial has been deprecated since Go 1.7: Use DialContext instead, which allows the transport to cancel dials as soon as they are no longer needed. If both are set, DialContext takes priority. (SA1019)
pkg/hubble/observer/local_observer.go:301:8: req.Experimental.GetFieldMask is deprecated: Marked as deprecated in observer/observer.proto. (SA1019)
pkg/hubble/observer/local_observer_test.go:311:19: out.Summary is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/hubble/observer/local_observer_test.go:313:22: last10Input[i].Summary is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/hubble/parser/fieldmask/fieldmask_test.go:62:17: assert.ObjectsExportedFieldsAreEqual is deprecated: Use [EqualExportedValues] instead. (SA1019)
pkg/hubble/parser/fieldmask/fieldmask_test.go:65:17: assert.ObjectsExportedFieldsAreEqual is deprecated: Use [EqualExportedValues] instead. (SA1019)
pkg/hubble/parser/fieldmask/fieldmask_test.go:77:17: assert.ObjectsExportedFieldsAreEqual is deprecated: Use [EqualExportedValues] instead. (SA1019)
pkg/hubble/parser/fieldmask/fieldmask_test.go:98:17: assert.ObjectsExportedFieldsAreEqual is deprecated: Use [EqualExportedValues] instead. (SA1019)
pkg/hubble/parser/seven/parser.go:140:2: decoded.DropReason is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/hubble/parser/seven/parser.go:152:2: decoded.Reply is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/hubble/parser/seven/parser.go:159:2: decoded.Summary is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/hubble/parser/sock/parser.go:125:2: decoded.Summary is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/hubble/parser/threefour/parser.go:205:2: decoded.DropReason is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/hubble/parser/threefour/parser.go:206:41: decoded.DropReason is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/hubble/parser/threefour/parser.go:217:2: decoded.Reply is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/hubble/parser/threefour/parser.go:226:2: decoded.Summary is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/hubble/parser/threefour/parser_test.go:496:31: f.GetDropReason is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/hubble/parser/threefour/parser_test.go:518:34: f.GetDropReason is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/hubble/parser/threefour/parser_test.go:789:24: f.GetReply is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/hubble/parser/threefour/parser_test.go:799:25: f.GetReply is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/hubble/parser/threefour/parser_test.go:809:25: f.GetReply is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/hubble/parser/threefour/parser_test.go:820:25: f.GetReply is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/hubble/parser/threefour/parser_test.go:831:25: f.GetReply is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/hubble/parser/threefour/parser_test.go:842:25: f.GetReply is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/hubble/parser/threefour/parser_test.go:853:25: f.GetReply is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/hubble/parser/threefour/parser_test.go:864:25: f.GetReply is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/hubble/parser/threefour/parser_test.go:874:25: f.GetReply is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/hubble/parser/threefour/parser_test.go:883:25: f.GetReply is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/hubble/parser/threefour/parser_test.go:891:25: f.GetReply is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/hubble/relay/server/server_test.go:300:22: f.Summary is deprecated: Marked as deprecated in flow/flow.proto. (SA1019)
pkg/k8s/apis/cilium.io/v2alpha1/bgpp_types.go:10:2: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (SA1019)
pkg/k8s/apis/cilium.io/v2alpha1/bgpp_types_test.go:10:2: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (SA1019)
pkg/k8s/apis/crdhelpers/register.go:227:9: wait.Poll is deprecated: This method does not return errors from context, use PollUntilContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release. (SA1019)
pkg/l2announcer/l2announcer_test.go:25:2: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (SA1019)
pkg/lock/stoppable_waitgroup_test.go:157:2: rand.Seed has been deprecated since Go 1.20 and an alternative has been available since Go 1.0: As of Go 1.20 there is no reason to call Seed with a random value. Programs that call Seed with a known value to get a specific sequence of results should use New(NewSource(seed)) to obtain a local random generator. (SA1019)
pkg/node/bootid_linux.go:7:2: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details. (SA1019)
pkg/wireguard/agent/agent_test.go:105:2: ipCache.Upsert is deprecated: Prefer UpsertLabels() instead. (SA1019)
pkg/wireguard/agent/agent_test.go:106:2: ipCache.Upsert is deprecated: Prefer UpsertLabels() instead. (SA1019)
pkg/wireguard/agent/agent_test.go:107:2: ipCache.Upsert is deprecated: Prefer UpsertLabels() instead. (SA1019)
pkg/wireguard/agent/agent_test.go:108:2: ipCache.Upsert is deprecated: Prefer UpsertLabels() instead. (SA1019)
pkg/wireguard/agent/agent_test.go:152:3: ipCache.Upsert is deprecated: Prefer UpsertLabels() instead. (SA1019)
pkg/wireguard/agent/agent_test.go:153:3: ipCache.Upsert is deprecated: Prefer UpsertLabels() instead. (SA1019)
pkg/wireguard/agent/agent_test.go:155:3: ipCache.Upsert is deprecated: Prefer UpsertLabels() instead. (SA1019)
pkg/wireguard/agent/agent_test.go:156:3: ipCache.Upsert is deprecated: Prefer UpsertLabels() instead. (SA1019)
pkg/wireguard/agent/agent_test.go:158:3: ipCache.Delete is deprecated: Prefer RemoveLabels() or RemoveIdentity() instead. (SA1019)
pkg/wireguard/agent/agent_test.go:159:3: ipCache.Delete is deprecated: Prefer RemoveLabels() or RemoveIdentity() instead. (SA1019)
pkg/wireguard/agent/agent_test.go:221:2: ipCache.Upsert is deprecated: Prefer UpsertLabels() instead. (SA1019)
pkg/wireguard/agent/agent_test.go:222:2: ipCache.Upsert is deprecated: Prefer UpsertLabels() instead. (SA1019)
Cilium should fix these issues as well as create CI that reports deprecated calls.
joestringer and dmefs
Metadata
Metadata
Assignees
Labels
good-first-issueGood starting point for new developers, which requires minimal understanding of Cilium.Good starting point for new developers, which requires minimal understanding of Cilium.kind/cfpCilium Feature ProposalCilium Feature Proposalkind/featureThis introduces new functionality.This introduces new functionality.
Type
Projects
Status
No status