Skip to content

LB-IPAM: Account for protocol differentiation in IP sharing checks #34677

@dylandreimerink

Description

@dylandreimerink

LB-IPAM has a feature which allows services to share an IP under a number of conditions. One of these is that ports are not allowed to overlap. So far, it didn't matter for which protocol these ports were since the Cilium datapath was unable to differentiate between TCP and UDP. Now that #33434 has merged, we should adjust this check so a service with port UDP/80 and and a service with port TCP/80 can share an IP.

The logic in question lives here:

for _, port1 := range sv.Ports {

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature/lb-ipamgood-first-issueGood starting point for new developers, which requires minimal understanding of Cilium.kind/enhancementThis would improve or streamline existing functionality.

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions