-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Closed
Copy link
Labels
area/metricsImpacts statistics / metrics gathering, eg via Prometheus.Impacts statistics / metrics gathering, eg via Prometheus.good-first-issueGood starting point for new developers, which requires minimal understanding of Cilium.Good starting point for new developers, which requires minimal understanding of Cilium.kind/cfpCilium Feature ProposalCilium Feature Proposalkind/enhancementThis would improve or streamline existing functionality.This would improve or streamline existing functionality.
Description
Issue
In the Cilium Helm chart is the creation of the metrics services for the cilium-agent and cilium-operator currently tied to the creation of service monitors, due to the IF statement requiring:
{{- if .Values.prometheus.serviceMonitor.enabled }} |
{{- if and .Values.operator.enabled .Values.operator.prometheus.enabled .Values.operator.prometheus.serviceMonitor.enabled }} |
This prevents use cases where the metrics are scraped but not using service monitors.
Solution
Remove the requirement for the service monitors to be enabled.
jiri-hlubek, michaeljsaenz, moto999999, rdrgporto and saiaunghlyanhtet
Metadata
Metadata
Assignees
Labels
area/metricsImpacts statistics / metrics gathering, eg via Prometheus.Impacts statistics / metrics gathering, eg via Prometheus.good-first-issueGood starting point for new developers, which requires minimal understanding of Cilium.Good starting point for new developers, which requires minimal understanding of Cilium.kind/cfpCilium Feature ProposalCilium Feature Proposalkind/enhancementThis would improve or streamline existing functionality.This would improve or streamline existing functionality.
Type
Projects
Status
Done