Skip to content

Creating metrics services is tied to the creation of service monitors #34466

@tschlaepfer

Description

@tschlaepfer

Issue

In the Cilium Helm chart is the creation of the metrics services for the cilium-agent and cilium-operator currently tied to the creation of service monitors, due to the IF statement requiring:

{{- if .Values.prometheus.serviceMonitor.enabled }}

{{- if and .Values.operator.enabled .Values.operator.prometheus.enabled .Values.operator.prometheus.serviceMonitor.enabled }}

This prevents use cases where the metrics are scraped but not using service monitors.

Solution

Remove the requirement for the service monitors to be enabled.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/metricsImpacts statistics / metrics gathering, eg via Prometheus.good-first-issueGood starting point for new developers, which requires minimal understanding of Cilium.kind/cfpCilium Feature Proposalkind/enhancementThis would improve or streamline existing functionality.

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions