Skip to content

submit-backport crashes if external reviewers are requested #21548

@gandro

Description

@gandro

The submit-backport script fails with the following error if one attempts to submit a backport PR with external contributors:

ontrib/backporting/submit-backport 1.12 v1.12-backport-2022-08-29.txt origin
....
Sending pull request...
remote:
remote: Create a pull request for 'pr/v1.12-backport-2022-08-29' on GitHub by visiting:
remote:      https://github.com/glibsm/cilium/pull/new/pr/v1.12-backport-2022-08-29
remote:
Error requesting reviewer: Unprocessable Entity (HTTP 422)
Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the cilium/cilium repository.

Signal ERR caught!

Traceback (line function script):
49 main contrib/backporting/submit-backport

Ideally, the script should not fail and instead avoid adding external contributors as reviewers. This is currently unfortunately enforced by the GitHub API, maybe we can try to add reviewers one by one.

cc @bimmlerd

Metadata

Metadata

Assignees

Labels

good-first-issueGood starting point for new developers, which requires minimal understanding of Cilium.kind/bugThis is a bug in the Cilium logic.sig/communityImpacts contribution workflow, guidelines, and tools.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions