-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Closed
Labels
area/agentCilium agent related.Cilium agent related.area/daemonImpacts operation of the Cilium daemon.Impacts operation of the Cilium daemon.kind/bugThis is a bug in the Cilium logic.This is a bug in the Cilium logic.kind/regressionThis functionality worked fine before, but was broken in a newer release of Cilium.This functionality worked fine before, but was broken in a newer release of Cilium.needs/triageThis issue requires triaging to establish severity and next steps.This issue requires triaging to establish severity and next steps.
Description
Is there an existing issue for this?
- I have searched the existing issues
What happened?
During local testing, we've discovered that router IP restoration from Kubernetes no longer seems to work:
- Does restoration from K8s even work? We fetch the k8s
Node
object (notCiliumNode
) and it no longer seems to contain an annotation with the router IP? And even with clusterpool, we callUpdateCiliumNodeResource
beforeWaitForNodeInformation
, which simply clears out the old router IP (and ignores the router IP from theNode
resource if it was present, but it anyway doesn't seem to be). At least with Kind, I have not been able to get it to work both before and after this PR
See discussion on the PR for some more investigation: #28781 (comment)
It seems that we no longer set annotations for the K8s node object. One question though is if we should actually restore the router IP from annotations, or if it would be better to use the CiliumNode object instead.
Cilium Version
v1.15-pre, but this might have been a regression since 1.13
Kernel Version
N/A
Kubernetes Version
N/A
Sysdump
No response
Relevant log output
No response
Anything else?
No response
Code of Conduct
- I agree to follow this project's Code of Conduct
Metadata
Metadata
Assignees
Labels
area/agentCilium agent related.Cilium agent related.area/daemonImpacts operation of the Cilium daemon.Impacts operation of the Cilium daemon.kind/bugThis is a bug in the Cilium logic.This is a bug in the Cilium logic.kind/regressionThis functionality worked fine before, but was broken in a newer release of Cilium.This functionality worked fine before, but was broken in a newer release of Cilium.needs/triageThis issue requires triaging to establish severity and next steps.This issue requires triaging to establish severity and next steps.