Skip to content

Catch malformed releases table before merging #13366

@joestringer

Description

@joestringer

These lines don't handle version substitution in a way that retains the valid structure of the table:

sed -i 's/\('$release'.*\)'$old_date'/\1'$new_date'/g' README.rst
sed -i 's/'$current'/'$latest'/g' README.rst
sed -i 's/\(projects\/\)'$old_proj'/\1'$new_proj'/g' $ACTS_YAML

As a result, we can unintentionally break the table and make it disappear entirely. It's easily fixed, for example:

#13365

However it would be better to catch before we merge it.

Possible paths:

  • Fix the script to make it understand the table better, or
  • Add a simple .RST validator for the README.rst to make sure that if we break the table, the CI will complain.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/CIContinuous Integration testing issue or flakearea/CI-improvementTopic or proposal to improve the Continuous Integration workflowarea/buildAnything to do with the build, more general than area/CIgood-first-issueGood starting point for new developers, which requires minimal understanding of Cilium.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions