Skip to content

Cilium 1.11.2. API Rate limit stopped working #18973

@Antiarchitect

Description

@Antiarchitect

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

This is Helm chart values.yaml piece:

  extraArgs:
    - "--api-rate-limit=endpoint-create=rate-limit:10/s,rate-burst:10,parallel-requests:10,auto-adjust:true"
    - "--api-rate-limit=endpoint-delete=rate-limit:10/s,rate-burst:10,parallel-requests:10,auto-adjust:true"
    - "--api-rate-limit=endpoint-get=rate-limit:10/s,rate-burst:10,parallel-requests:10,auto-adjust:true"
    - "--api-rate-limit=endpoint-list=rate-limit:10/s,rate-burst:10,parallel-requests:10,auto-adjust:true"
    - "--api-rate-limit=endponit-patch=rate-limit:10/s,rate-burst:10,parallel-requests:10,auto-adjust:true"

It worked on 1.11.1 and in 1.11.2 I have:

level=fatal msg="unable to parse api-rate-limit: 'endpoint-list=rate-limit:10/s,rate-burst:10,parallel-requests:10,auto-adjust:true,endponit-patch=rate-limit:10/s,rate-burst:10,parallel-requests:10,auto-adjust:true,endpoint-create=rate-limit:10/s,rate-burst:10,parallel-requests:10,auto-adjust:true,endpoint-delete=rate-limit:10/s,rate-burst:10,parallel-requests:10,auto-adjust:true,endpoint-get=rate-limit:10/s,rate-burst:10,parallel-requests:10,auto-adjust:true' is not formatted as key=value,key1=value1" subsys=config

How to set API rate limits properly now?

Cilium Version

1.11.2

Kernel Version

Linux worker-1.prod.xxx 5.15.7-1.el7.elrepo.x86_64 #1 SMP Mon Dec 6 12:52:14 EST 2021 x86_64 x86_64 x86_64 GNU/Linux

Kubernetes Version

Client Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.5", GitCommit:"5c99e2ac2ff9a3c549d9ca665e7bc05a3e18f07e", GitTreeState:"clean", BuildDate:"2021-12-16T08:38:33Z", GoVersion:"go1.16.12", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.5", GitCommit:"5c99e2ac2ff9a3c549d9ca665e7bc05a3e18f07e", GitTreeState:"clean", BuildDate:"2021-12-16T08:32:32Z", GoVersion:"go1.16.12", Compiler:"gc", Platform:"linux/amd64"}

Sysdump

No response

Relevant log output

No response

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

Labels

kind/bugThis is a bug in the Cilium logic.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions