Skip to content

workflows: add warning/explanation for testing workflow changes #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2021
Merged

workflows: add warning/explanation for testing workflow changes #441

merged 1 commit into from
Jul 20, 2021

Conversation

nbusseneau
Copy link
Member

This should help clarify that any changes to workflow files or workflow scripts should be tested from a PR using the pull_request trigger before merging.

@nbusseneau
workflows: add warning/explanation for testing workflow changes
11706e4 
This should help clarify that any changes to workflow files or workflow
scripts should be tested from a PR using the `pull_request` trigger
before merging.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@nbusseneau nbusseneau added the area/CI Continuous Integration testing issue or flake label Jul 19, 2021
@nbusseneau nbusseneau requested review from a team as code owners July 19, 2021 09:44
@nbusseneau nbusseneau requested review from nebril and joestringer July 19, 2021 09:44
@nbusseneau nbusseneau temporarily deployed to ci July 19, 2021 09:44 Inactive
@nbusseneau
Copy link
Member Author

nbusseneau commented Jul 19, 2021 •
edited
Loading

Note: EKS workflows failed with expected failure following merge of #400. Fix will be in #442.
Since the changes are completely unrelated to EKS, we are safe to merge without rebase/retest. We can mark as ready-to-merge once all reviews are in.

@nbusseneau nbusseneau added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 19, 2021
@tklauser tklauser merged commit 2df042a into master Jul 20, 2021
@tklauser tklauser deleted the pr/workflows-add-test-warning branch July 20, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@joestringer joestringer joestringer approved these changes

@nebril nebril Awaiting requested review from nebril

Assignees

@nebril nebril

Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nbusseneau @tklauser @joestringer @nebril