Skip to content

Refactor extractFeaturesFromConfigMap #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2023
Merged

Refactor extractFeaturesFromConfigMap #1991

merged 1 commit into from
Sep 27, 2023

Conversation

michi-covalent
Copy link
Contributor

@michi-covalent michi-covalent commented Sep 27, 2023 •
edited
Loading

  • Move the code to get the Cilium ConfigMap out of the loop to avoid
    getting it multiple times.
  • Associate extractFeaturesFromConfigMap with FeatureSet instead of
    ConnectivityTest.
  • Add unit tests.

Ref: #1962

@michi-covalent michi-covalent temporarily deployed to ci September 27, 2023 17:01 — with GitHub Actions Inactive
@michi-covalent michi-covalent force-pushed the pr/michi/amazing-optimization branch from 472fbd4 to baaa1c3 Compare September 27, 2023 17:24
@michi-covalent michi-covalent force-pushed the pr/michi/amazing-optimization branch from baaa1c3 to 509341e Compare September 27, 2023 17:25
@michi-covalent michi-covalent force-pushed the pr/michi/amazing-optimization branch from 509341e to 02b1465 Compare September 27, 2023 17:26
@michi-covalent michi-covalent temporarily deployed to ci September 27, 2023 17:26 — with GitHub Actions Inactive
@michi-covalent michi-covalent changed the title stuff Refactor extractFeaturesFromConfigMap Sep 27, 2023
@michi-covalent michi-covalent force-pushed the pr/michi/amazing-optimization branch from 02b1465 to 88ab044 Compare September 27, 2023 17:39
@michi-covalent michi-covalent temporarily deployed to ci September 27, 2023 17:39 — with GitHub Actions Inactive
@michi-covalent
Refactor extractFeaturesFromConfigMap()
7298304 
- Move the code to get the Cilium ConfigMap out of the loop to avoid
  getting it multiple times.
- Associate extractFeaturesFromConfigMap() with FeatureSet instead of
  ConnectivityTest.
- Add unit tests.

Ref: #1962

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent force-pushed the pr/michi/amazing-optimization branch from 88ab044 to 7298304 Compare September 27, 2023 19:57
@michi-covalent michi-covalent temporarily deployed to ci September 27, 2023 19:57 — with GitHub Actions Inactive
@michi-covalent michi-covalent marked this pull request as ready for review September 27, 2023 20:49
@michi-covalent michi-covalent requested a review from a team as a code owner September 27, 2023 20:49
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 27, 2023
@michi-covalent michi-covalent merged commit f5ac977 into main Sep 27, 2023
@michi-covalent michi-covalent deleted the pr/michi/amazing-optimization branch September 27, 2023 23:02
@joestringer joestringer mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michi-covalent @christarazi