Skip to content

Clean up the node feature detection logic #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2023
Merged

Clean up the node feature detection logic #1990

merged 1 commit into from
Sep 27, 2023

Conversation

michi-covalent
Copy link
Contributor

  • Remove nodesWithoutCilium list as it is redundant, and rename nodesWithoutCiliumMap to nodesWithoutCilium.
  • Initialize both nodes and nodesWithoutCilium in getNodes to avoid listing nodes twice.
  • Associate extractFeaturesFromNodes with FeatureSet instead of ConnectivityTest to decouple FeatureSet from ConnectivityTest.

Ref: #1962

@michi-covalent michi-covalent temporarily deployed to ci September 26, 2023 23:39 — with GitHub Actions Inactive
@michi-covalent
Clean up the node feature detection logic
68cd591 
- Remove nodesWithoutCilium list as it is redundant, and rename
  nodesWithoutCiliumMap to nodesWithoutCilium.
- Initialize both nodes and nodesWithoutCilium in getNodes to avoid
  listing nodes twice.
- Associate extractFeaturesFromNodes with FeatureSet instead of
  ConnectivityTest to decouple FeatureSet from ConnectivityTest.

Ref: #1962

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent temporarily deployed to ci September 27, 2023 00:44 — with GitHub Actions Inactive
@michi-covalent michi-covalent marked this pull request as ready for review September 27, 2023 02:25
@michi-covalent michi-covalent requested a review from a team as a code owner September 27, 2023 02:26
tklauser
tklauser approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 27, 2023
@tklauser tklauser merged commit 33f60a5 into main Sep 27, 2023
@tklauser tklauser deleted the pr/michi/node branch September 27, 2023 06:51
@joestringer joestringer mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michi-covalent @tklauser