Validate Helm chart #125
Merged
Validate Helm chart #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51cbdf6 to
c584393
Compare
nathanjsweet
approved these changes
May 22, 2024
aanm
requested changes
May 27, 2024
|
moving back to draft |
cc923e1 to
57820f2
Compare
Running cilium connectivity test is a bit of an overkill for Helm chart validation at this point. Let's do this instead: - For pull request trigger, validate that relevant image tags in the new chart match the chart version. I think this is a good sanity check to run before publishing the chart. - For push trigger, download the published chart from helm.cilium.io and run the same validation. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
57820f2 to
915c3cc
Compare
michi-covalent
commented
May 29, 2024
aanm
approved these changes
May 29, 2024
michi-covalent
added a commit
to cilium/release
that referenced
this pull request
May 29, 2024
- Point to RELEASE.md instead of generate_helm_release.sh. RELEASE.md contains instructions for using the script. - conformance-gke.yaml has been replaced by validate-cilium-chart.yaml. Ref: cilium/charts#114 Ref: cilium/charts#125 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
to cilium/release
that referenced
this pull request
May 30, 2024
- Point to RELEASE.md instead of generate_helm_release.sh. RELEASE.md contains instructions for using the script. - conformance-gke.yaml has been replaced by validate-cilium-chart.yaml. Ref: cilium/charts#114 Ref: cilium/charts#125 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running cilium connectivity test is a bit of an overkill for Helm chart
validation at this point. Let's do this instead:
chart match the chart version. I think this is a good sanity check to
run before publishing the chart.
run the same validation.