Fix EOL-related hash comparison bug #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a preparation for adding unit tests for hash comparison logic.
Use just one copy of line ending variations list for all hash comparisons.
Hash comparison should ignore end-of-line variations, but it fails in one scenario: - when the original hash was calculated by an older RH version, which didn't normalize the script to LF line endings before hashing - and the original script had CRLF line endings - and the same file, but with LF line endings, is executed by the migrator. This commit adds unit tests which excercise all possible EOL combinations to demonstrate the bug.
Fix incorrectly detected script changes in one scenario.
|
@jjanuszkiewicz Nice separation of the hash algorithm into a separate class and interface. And good catch. Thank you very much for your contribution! :) |
|
@erikbra Thanks for merging this :-) Any idea when 1.2.0 will be released? My team is waiting for this fix, as we've actually been hit by this problem in practice. I'd rather not build our own temporary clone of RH if I can avoid it. |
|
The plan is to get it out by the end of the month. I have two more features I would like to include (open PRs), if possible. https://github.com/chucknorris/roundhouse/milestone/10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hash comparison should ignore end-of-line variations, but it fails in one scenario:
This PR refactors hash generation and comparison into a separate class, adds unit tests that demonstrate the bug and fixes it.