Skip to content

Feature/redshift support #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 14, 2019

Conversation

neoaisac
Copy link
Contributor

@neoaisac neoaisac commented Sep 20, 2019

Adds initial AWS Redshift support for RoundhousE.

@neoaisac
Copy link
Contributor Author

@erikbra I thought I'd do the PR as we're already running locally with an alpha version for Redshift based on this code. I'd like to have someone reviewing the code (it's my first public OSS commit in years) :)

@erikbra
Copy link
Member

erikbra commented Oct 13, 2019

@neoaisac Thanks a lot for your PR. And terribly sorry for the long time before any feedback from my part. Work and other parts of my life has made RoundhousE bump down the list of priorities. I think your PR looks nice and clean.

Just a quick question, I don't know Amazon Redshift, and I just wondered why you have made the implementations subclass NpgSql? Is Redshift based on PostgreSQL?

@erikbra erikbra added this to the 1.2.0 milestone Oct 13, 2019
@neoaisac
Copy link
Contributor Author

Hi @erikbra. Redshift uses a somewhat compatible interface based on PostgreSQL 8.0.2, however it's not 100% PostgreSQL. There are some things that don't work, and some things that don't work as expected in PostgreSQL standard.

Maybe this helps:

@erikbra
Copy link
Member

erikbra commented Oct 14, 2019

Thanks a lot for the update, @neoaisac . I tried reading up on it on the Amazon Redshift website, but my google fu wasn't up to par, apparently :)

I presumed it was based upon PostgreSQL, since you made it inherit that, I just wanted to be sure and know a bit more before merging.

Again, thanks a lot for your PR.

@erikbra erikbra merged commit 6ee5384 into chucknorris:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants