Nuget all the things - no more ILMerge #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14c1d95 to
fa5ae40
Compare
4f02f50 to
7c3ef35
Compare
* Added scripts for running PostgreSQL integration tests * Replaced ILMerge with Costura.Fody * Fixed some path problems Packaging restructuring * Changed all RoundhousE database DLLs to be nuget packages of their own. * Simplified build scripts
0bdae95 to
472efd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been multiple issues with ILMerge-ing the assemblies, both the roundhouse lib and rh.exe. This PR splits up roundhouse.lib in multiple nuget packages, so that the consumers can depend on only the one they need, and not pull inn dependencies to totally different database providers.
It also uses Fody/Costura instead of ILMerge, as ILMerge seems to not keep up with the developments in other nuget packages, they stop working when ILMerge-d because of usage of reflection internally. Fody/Costura embeds the dependencies as Assembly resources (compressed) instead of merging them, and injects code to use the embedded assemblied on assembly loading.
Some rewrites to simplify deploy and dependency management
Packaging restructuring