Changed exception logging to include exception details/stacktrace #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks, I will take a look at it. |
|
This is in, thanks! |
GoogleCodeExporter
pushed a commit
to google-code-export/roundhouse
that referenced
this pull request
Mar 13, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the way exceptions are logged, was struggling with rh.exe failing with only this output:
"The type initializer for 'StructureMap.StructureMapConfiguration' threw an exception."
No details of the internal exception or stacktrace is shown, this made this problem hard to find. After switching to using Log4nets Error method (ex.Message, ex) the message AND internal exception message/stack trace is printed to the console/output making this problem easy to identity (caused by .NET framework 3.5 was not installed on buildserver).