Refactors fromString implementation #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,6 +14,46 @@ | |||
| * {a: 1, b: 2, c: 3, d: 4, c: 5, e: 6} | |||
| */ | |||
| export function fromString (string) { | |||
| const parseFloatOrThrow = number => { | |||
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
This PR refactors
fromString(matrix)function with the following benefits:parseFloat()that ignores them.!Number.isFinite()(e.g. two)Previous implementation where not fully validating number, providing in some case
Number.NaNas output. This new version strictly validate number and may break some part of your code that were silently failing.This table shows some examples:
matrix(ee,ee,ee,ee,ee,ee){ a: NaN, b: NaN, c: NaN, d: NaN, e: NaN, f: NaN }Error("'matrix(ee,ee,ee,ee,ee,ee)' is not a matrix")matrix(1px,2px,3px,4px,5px,6px)Error("'matrix(1px,2px,3px,4px,5px,6px)' is not a matrix"){ a: 1, b: 2, c: 3, d: 4, e: 5, f: 6 }🙅 backward compatibility
In a case that you want still to use the previous implementation, you can replace
fromString(matrix)withfromStringLegacy(matrix). At the same time, open an issue in order to show your use case, because future implementations will remove the legacy method.