Skip to content

[ENH]: add cache mount & tolerations to garbage collector template in Helm chart #5016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2025
Merged

[ENH]: add cache mount & tolerations to garbage collector template in Helm chart #5016

merged 1 commit into from
Jul 2, 2025

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Jul 1, 2025 •
edited
Loading

Description of changes

Adds options for a cache mount and tolerations to the garbage collector template. We want to enable sparse index caching on disk.

Test plan

How are these changes tested?

Validated that the pod created with tilt up has a /cache/ directory.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2025 •
edited
Loading

✅ The Helm chart's version was changed. Your changes to the chart will be published upon merge to main.

@codetheweb codetheweb force-pushed the feat-helm-chart-gc-cache-tolerations branch from 99afb71 to 25422de Compare July 1, 2025 23:39
@codetheweb codetheweb force-pushed the feat-helm-chart-gc-cache-tolerations branch from 25422de to 9a452f4 Compare July 1, 2025 23:40
@codetheweb codetheweb marked this pull request as ready for review July 1, 2025 23:41
@codetheweb codetheweb requested a review from jasonvigil July 1, 2025 23:41
@propel-code-bot propel-code-bot
Copy link
Contributor

Add Cache Mount and Tolerations to Garbage Collector Helm Template

This PR enhances the distributed-chroma Helm chart by introducing configurable cache mount options and tolerations for the garbage collector component. These additions enable disk-based sparse index caching and allow for pod scheduling customization via tolerations.

Key Changes:
• Added a conditional volume and mount for cache storage in the garbage collector StatefulSet template.
• Included cache configuration options (hostPath, mountPath) in values.yaml.
• Introduced support for tolerations and node selectors in the garbage collector Helm manifest.
• Bumped Helm chart version to 0.1.49.

Affected Areas:
• k8s/distributed-chroma/templates/garbage-collector.yaml
• k8s/distributed-chroma/values.yaml
• k8s/distributed-chroma/Chart.yaml

This summary was automatically generated by @propel-code-bot

@codetheweb codetheweb enabled auto-merge (squash) July 1, 2025 23:43
@codetheweb codetheweb merged commit 4570cd0 into main Jul 2, 2025
58 checks passed
@codetheweb codetheweb deleted the feat-helm-chart-gc-cache-tolerations branch July 2, 2025 00:04
Inventrohyder pushed a commit to Inventrohyder/chroma that referenced this pull request Aug 5, 2025
@codetheweb @Inventrohyder
[ENH]: add cache mount & tolerations to garbage collector template in…
7e050e4 
… Helm chart (chroma-core#5016)

## Description of changes

Adds options for a cache mount and tolerations to the garbage collector
template. We want to enable sparse index caching on disk.

## Test plan

_How are these changes tested?_

Validated that the pod created with `tilt up` has a `/cache/` directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonvigil jasonvigil jasonvigil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codetheweb @jasonvigil