Fix divide by zero warning in pymbar3 #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhang-ivy boot strapping has been merged, after we get this PR merged in, I think we are ready for a new pymbar3 LTS release? |
|
@mikemhenry : Yes, I agree! |
Codecov Report
|
|
Probably should do a bit of adjustment on the RTD manual and the docstrings, but depends on the urgency of release. |
|
@mrshirts are there some formatting errors? I am looking at RTD now to make sure we build the 3.0.x version. |
|
It didn't do things like have many of the modules documented, etc. I had a todo to go in and clean things up, but have not done that yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports some pymbar4 changes to resolve the warning.
See this comment for explanation for why the warning arises in pymbar3, but not pymbar4