-
Notifications
You must be signed in to change notification settings - Fork 3
Description
TL;DR
There are a ton HTTP clients on CRAN, and many of them make single pass-or-fail HTTP requests. If they added some retry logic (with httr::RETRY()
), they would be more resilient to transient issues like brief network disruptions or service downtime.
Details
{httr}
is a super-popular package for making HTTP requests in R and handling their response. It has a LOT of direct reverse imports, and impacts a lot of other projects indirectly.
I have seen many examples of packages where people use functions like httr::GET()
, httr::POST()
, httr::VERB()
, etc. to make HTTP requests. These functions attempt to make a single request and raise an error if anything goes wrong.
I believe (though I don't know for sure) that this all-or-nothing approach is not something package authors have carefully and intentionally chosen, and changing those calls to httr::RETRY()
would make those packages more resilient to transient problems like brief network outages or periods where the service(s) it hits are overwhelmed. In my experience, using retry logic can improve the user experience with HTTP clients.
I propose a group spend some time improving the ecosystem of HTTP clients in R by repeating these steps:
- choose a package from the
{httr}
reverse imports - go to the package's source code on GitHub (if it exists)
- find all references to
httr::GET()
,httr::POST()
,httr::PUT()
,httr::VERB()
,httr::DELETE()
,httr::HEAD()
, andhttr::PATCH()
and replace them with the appropriatehttr::RETRY()
- create a pull request with the change, including some text in the summary explaining to the package author how this change will make their code more reliable (see added retry logic to HTTP calls ropensci/eia#5 for an example)
I'd be happy to start out with a short introduction to HTTP and what httr::RETRY()
actually does.