[testing] Mangle more directories #4927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Directories created with `[;<>]` are problematic for Makefiles and/or Verilator. Drop these if we see them. This fixes issues where tests, converted to ChiselSim, will fail to compile through Verilator due to observed use of semicolons in test scopes or serialization of Chisel types, e.g., `UInt<16>`. Note: the continued patching of this indicates that we should setup an allowlist of legal characters as opposed to continuing to exlcude characters. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
jackkoenig
approved these changes
May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directories created with
[;<>]are problematic for Makefiles and/orVerilator. Drop these if we see them. This fixes issues where tests,
converted to ChiselSim, will fail to compile through Verilator due to
observed use of semicolons in test scopes or serialization of Chisel
types, e.g.,
UInt<16>.Note: the continued patching of this indicates that we should setup an
allowlist of legal characters as opposed to continuing to exlcude
characters.
Release Notes
Drop
;,<, and>if they show up in a ChiselSim Scalatest scope name. This fixes a bug where Verilator (or the generated Makefile for ChiselSim) could fail to compile if it sees directories with these characters.