Skip to content

Conversation

kammoh
Copy link
Contributor

@kammoh kammoh commented Apr 30, 2025

This allows adding arbitrary flags to the executed verilator command.
An example use case for me was adding "--trace-max-array" to be able to trace arrays in the generated waveforms.
Exposing all verilator flag in CompilationSettings seems impossible so this could be a way to allow for different use cases without cluttering up the Chisel side.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig requested a review from seldridge April 30, 2025 04:26
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the PR instead add any option that it needs on-demand?

I.e., if this is. done to add --max-trace-array, then add that.

I realize that this approach will make each backend's compilation options get comically large. However, it's more typesafe, it avoids having two ways to do things (outputSplitCFuncs can then be specified two ways), and it's consistent with the direction that the project has started down.

So, add whatever you want! If it turns into 800 options, I'm fine with that. 😅

@kammoh
Copy link
Contributor Author

kammoh commented Apr 30, 2025

Fair enough. Replaced with #4911

@kammoh kammoh closed this Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants