Upgrade to Mill 1.0.0 #4972
Merged
Upgrade to Mill 1.0.0 #4972
+271
−245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c74a32f to
563538d
Compare
seldridge
approved these changes
Jul 11, 2025
| s"$previousTagNoV+$commitsSincePreviousTag-$currentCommit-SNAPSHOT" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Not actionable in this PR: doing a simpler git --describe --tag as opposed to rolling our own here would be good. Granted, this differs slightly from your format as it adds the g before the $currentCommit and appends -SNAPSHOT:
# git describe --tag
v7.0.0-RC2-4-gece296e71
There was a problem hiding this comment.
I prefer our versioning to the default output of git describe as it more closely matches what other Scala projects do.
That being said I think a regex to convert the output of git describe --tag would perhaps be simpler.
Comment on lines
-38
to
+40
| def scalaLibraryIvy = v.scalaLibrary(crossScalaVersion) | ||
| def scalaReflectIvy = v.scalaReflect(crossScalaVersion) | ||
| def scala2CompilerIvy: Dep = v.scala2Compiler(crossScalaVersion) | ||
| def scala3CompilerIvy: Dep = v.scala3Compiler(crossScalaVersion) | ||
| def scalaLibraryMvn = v.scalaLibrary(crossScalaVersion) | ||
| def scalaReflectMvn = v.scalaReflect(crossScalaVersion) | ||
| def scala2CompilerMvn: Dep = v.scala2Compiler(crossScalaVersion) | ||
| def scala3CompilerMvn: Dep = v.scala3Compiler(crossScalaVersion) |
There was a problem hiding this comment.
Thanks for updating the method names even though this was not necessary. 👍
There was a problem hiding this comment.
FWIW it was sort of a happy accident, I updated these with sed 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mill 1.0.0 is here 🎉. We badly need this so we can publish Snapshots to Maven Central.
Lots to be aware of for Chisel developers:
ivyhas been replaced withmvn(which makes more sense)Aggis gone, just useSeqBuildCtx.watchValuedue to sandboxingVcsVersionhas not yet been published for Mill 1.0.0 (not even the RCs) so I just re-implemented itdocsis lousy with doing things outside of theout/folder which is bad, but rather than tweaking all of that, I just guarded withBuildCtx.withFilesystemCheckerDisabled, we should try to remove those.crossbusiness but I will leave that for follow on work.Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
No SNAPSHOT publishing yet, that will be follow on work. See the Mill 1.0.0 changelog.
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash)and clean up the commit message.Create a merge commit.