Skip to content

Conversation

adkian-sifive
Copy link
Contributor

The format of resource files that point the Scala compiler to user plugins has changed in Scala 3. Specifically, Scala 3 expects a plugin.properties file that is formatted like a Linux config file. Using Mill's override resources functionality we split plugin/src/main/resources to plugin/src/main/resources-2 and /plugin/src/main/resources-3

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Split plugin resource files into separate directories for Scala 2 and Scala 3

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@adkian-sifive adkian-sifive added the Scala 3 Changes related to upgrading to Scala 3 label Jul 10, 2025
@adkian-sifive adkian-sifive mentioned this pull request Jul 10, 2025
14 tasks
@jackkoenig jackkoenig merged commit 6496608 into main Jul 10, 2025
18 checks passed
@jackkoenig jackkoenig deleted the adkian-sifive/scala3-plugin-resources branch July 10, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scala 3 Changes related to upgrading to Scala 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants