Skip to content

Add Lookupable for ActualDirection #4950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 9, 2025
Merged

Add Lookupable for ActualDirection #4950

merged 3 commits into from
Jun 9, 2025
+35 −12

Conversation

tmckay-sifive
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

  • Allow ActualDirection to be looked up from a Hierarchy

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@tmckay-sifive tmckay-sifive added the Feature New feature, will be included in release notes label Jun 9, 2025
@tmckay-sifive
Copy link
Contributor Author

Feature feels like overkill for this tiny change, but no other labels seemed appropriate.

@tmckay-sifive tmckay-sifive requested a review from jackkoenig June 9, 2025 17:13
jackkoenig
jackkoenig reviewed Jun 9, 2025
View reviewed changes
core/src/main/scala/chisel3/Data.scala Outdated
Comment on lines 195 to 196
implicit def lookupableDirection: Lookupable.Simple[ActualDirection] =
Lookupable.isLookupable[ActualDirection]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this to object Lookupable along with the other ones, also good to add a sanity test, see #4497 for an example. It would be reasonable to merge a lot of the "simple lookupable" tests into a single test instead of separate ones for each.

jackkoenig
jackkoenig reviewed Jun 9, 2025
View reviewed changes
@jackkoenig jackkoenig enabled auto-merge (squash) June 9, 2025 21:13
@jackkoenig jackkoenig merged commit 86f73ad into chipsalliance:main Jun 9, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
Feature New feature, will be included in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmckay-sifive @jackkoenig