Skip to content

[Scala3] Add Bundle plugin #4947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Jul 11, 2025
Merged

[Scala3] Add Bundle plugin #4947

merged 31 commits into from
Jul 11, 2025
+285 −13

Conversation

adkian-sifive
Copy link
Contributor

@adkian-sifive adkian-sifive commented Jun 4, 2025 •
edited
Loading

Chisel's Bundle transform for Scala 3.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Adds Bundle plugin

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@adkian-sifive adkian-sifive added the Scala 3 Changes related to upgrading to Scala 3 label Jun 4, 2025
@adkian-sifive adkian-sifive marked this pull request as ready for review June 18, 2025 19:19
@adkian-sifive adkian-sifive force-pushed the adkian-sifive/scala3-bundle-plugin branch from 7846562 to 0b56d54 Compare June 18, 2025 19:21
jackkoenig
jackkoenig reviewed Jun 25, 2025
View reviewed changes
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, a few comments, and it seems CI isn't working so need to get that fixed.

@adkian-sifive adkian-sifive force-pushed the adkian-sifive/scala3-bundle-plugin branch from 8c0e236 to b107be4 Compare July 10, 2025 03:03
jackkoenig
jackkoenig reviewed Jul 10, 2025
View reviewed changes
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but some nits and requests

@adkian-sifive
Initial bundle component
e4a7ab4
@adkian-sifive
tuple attempt
b3cbb43
@adkian-sifive
tuple in vecs
468f491
@adkian-sifive
Add bundlecomponent for now
6b5be10 
final version should handle both phases
@adkian-sifive
Tuples getting closer
cb81ddc
@adkian-sifive
giving up on prior approach
e666231
@adkian-sifive
updates
68f60e1
@adkian-sifive
Fix issue with arity
0750731
@adkian-sifive
Working bundle plugin
34a2ea7
@adkian-sifive
Cleanup
acb2b84
@adkian-sifive
Replace Seq type with Iterable
6bb9fa4
@adkian-sifive
Fixes to makeArray
eed7fef 
Run Scalafmt
@adkian-sifive
Sensible plugin and phase naming
0d46263 
Update plugin file names
@adkian-sifive
Scalafmt
343c9f3
@adkian-sifive
Clean up plugin types
72b9da0
@adkian-sifive
Remove symbol.record.owner from new symbol definition
52ea5d9 
This was causing _elementsImpl to not get inserted correctly for
anonymous Bundle instances
@adkian-sifive
Add dynamic select for Bundles
843c60c 
This is needed because Scala 3 does not support type inference for
refinement types over anonymous classes
@adkian-sifive
Cleanup and formatting
faf2cb0
@adkian-sifive
Unified Plugin class with naming and bundle phases
3d5315f
@adkian-sifive
Rename plugin files to phases
604ae8c
@adkian-sifive
Add comment to Scala 3 selectDynamic
bab1bd9
@adkian-sifive
Code review updates
7746e6a
@adkian-sifive adkian-sifive force-pushed the adkian-sifive/scala3-bundle-plugin branch from 82fc2cc to d3417d9 Compare July 10, 2025 23:26
jackkoenig
jackkoenig reviewed Jul 11, 2025
View reviewed changes
jackkoenig
jackkoenig reviewed Jul 11, 2025
View reviewed changes
jackkoenig
jackkoenig approved these changes Jul 11, 2025
View reviewed changes
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@adkian-sifive adkian-sifive enabled auto-merge (squash) July 11, 2025 03:57
@adkian-sifive adkian-sifive merged commit 579d187 into main Jul 11, 2025
15 checks passed
@adkian-sifive adkian-sifive deleted the adkian-sifive/scala3-bundle-plugin branch July 11, 2025 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

@seldridge seldridge Awaiting requested review from seldridge

Assignees
No one assigned
Labels
Scala 3 Changes related to upgrading to Scala 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adkian-sifive @jackkoenig