Skip to content

Conversation

jackkoenig
Copy link
Contributor

AffectsChiselName is new in 7.0 so no reason to backport.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

Previously, naming support on unapply only worked for subtypes of Data, but now it works for all namable types, including user-extensible AffectsChiselName as well as non-Data Chisel built-in types: Mem, VerificationStatement, properties.DynamicObject, and Disable.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

Previously, naming support on unapply only worked for subtypes of Data,
but now it works for all namable types, including user-extensible
AffectsChiselName as well as non-Data Chisel built-in types: Mem,
VerificationStatement, properties.DynamicObject, and Disable.
@jackkoenig jackkoenig added this to the 7.0 milestone May 30, 2025
@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label May 30, 2025
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackkoenig jackkoenig enabled auto-merge (squash) May 30, 2025 22:59
@jackkoenig jackkoenig merged commit 54860a0 into main May 30, 2025
17 checks passed
@jackkoenig jackkoenig deleted the fix-naming-plugin-unapply branch May 30, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants