Skip to content

Conversation

seldridge
Copy link
Member

Add more type classes that can be used to modify the Chisel and firtool options of ChiselSim's SimulatorAPI methods.

While the number of type classes here is getting comical, these are being added to fill two remaining gaps. We need the ability to control, via command line arguments, certain options. With Scalatest, the only way to do this is via -D options. However, the way to use -D options is via the HasCliOptions API which is implemented via this type class pattern.

Release Notes

Provide infrastructure for allowing modifications to Chisel and firtool command line arguments when running ChiselSim tests, e.g., via the Scalatest command line.

Add more type classes that can be used to modify the Chisel and `firtool`
options of ChiselSim's `SimulatorAPI` methods.

While the number of type classes here is getting comical, these are being
added to fill two remaining gaps.  We need the ability to control, via
command line arguments, certain options.  With Scalatest, the only way to
do this is via `-D` options.  However, the way to use `-D` options is via
the `HasCliOptions` API which is implemented via this type class pattern.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
@seldridge seldridge added the Feature New feature, will be included in release notes label Mar 17, 2025
@seldridge seldridge requested a review from jackkoenig March 17, 2025 23:35
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seldridge seldridge merged commit 7965f8e into main Mar 17, 2025
17 of 18 checks passed
@seldridge seldridge deleted the dev/seldridge/just-one-more-type-class-bro branch March 17, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants