[chiselsim] HasCliOptions, EmitVcd for ChiselSim #4807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the `HasCliOptions` and `Cli.EmitVcd` traits to the Scalatest ChiselSim trait. This provides a saner default for end users: 1. Command line options are not allowed to sneak in through Scalatest's ConfigMap and must go through normal option parsing paths. 2. The default ChiselSim environment will always have `-DemitVcd=true` as an available option. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
HasCliOptionsandCli.EmitVcdtraits to the Scalatest ChiselSim trait. This provides a saner default for end users:-DemitVcd=trueas an available option.Release Notes
scalatest.ChiselSimtrait to require that any command line options are passed using theaddOptionmethod. Users will no longer be able to use Scalatest's ConfigMap directly. This is done for safety reasons. If users would like different behavior, they can construct their ownChiselSimtrait from the traits they would prefer.-DemitVcd=trueoption toscalatest.ChiselSim. Users can now run any simulation and turn on waveforms by passing this option to Scalatest.