Remove deprecated annotation APIs #4717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1a043e7 to
1a7dbe2
Compare
seldridge
approved these changes
Feb 22, 2025
Comment on lines
-616
to
+615
| def annotations: ArrayBuffer[ChiselAnnotation] = dynamicContext.annotations | ||
| def annotations: ArrayBuffer[() => Seq[Annotation]] = dynamicContext.annotations |
There was a problem hiding this comment.
At a very basic level, this kind of cleanup is great. Previously, we were using a class that was wrapping a function. Now we are directly using a function. 💯
| annotations.foreach(annotate(_)) | ||
| // annotate doesn't support InstanceId (which is deprecated) because InstanceId doesn't implement toRelativeTarget | ||
| // this API is deprecated anyway so probably fine to not check it. | ||
| annotate()(Seq(SinkAnnotation(component.toNamed, name)) ++ Option.when(disableDedup)(NoDedupAnnotation(moduleName))) |
There was a problem hiding this comment.
That seems okay to me. Also, given that this is deprecated since 6.0, delete in a follow-on? 💣
There was a problem hiding this comment.
That was exactly my thinking, I just figured it should be a separate PR
* Remove ChiselAnnotation and ChiselMultiAnnotation * Remove annotate methods for ChiselAnnotations * Remove Circuit APIs from ChiselOptions and ChiselCircuitAnnotation * Use ElaboratedCircuit instead * Remove ChiselEnum related annotations
1a7dbe2 to
c5f0b60
Compare
tymcauley
added a commit
to tymcauley/rocket-chip
that referenced
this pull request
Mar 7, 2025
This feature is being removed from Chisel 7: chipsalliance/chisel#4717 These custom annotations aren't used by `firtool`, so their removal doesn't impact that tool's outputs.
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables #4644
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash)and clean up the commit message.Create a merge commit.