Dev/seldridge/switch to chisel settings #4708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new case class, `ChiselSettings`, which will be the main structure for configuring the Chisel/FIRRTL/Verilog ABI parts of a simulation. While this may overlap with common compilation settings or backend compilation settings, this is intended to provide the Chisel user view of these as opposed to exposign the low-level details of the latter two. Currently, this only includes layer control. This is part of a patch series that will replace existing arguments of layer control type to use this new Chisel settings structure. In later patches, new members will be added to Chisel settings. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Change SimulatorAPI methods to use the ChiselSettings class instead of directly communicating layerControl. This will enable us to lump together more options that all are associated with Chisel/FIRRTL/the Verilog ABI. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
jackkoenig
approved these changes
Feb 19, 2025
|
Exactly, never released. I'll deal with the fallout internally to get this converted over in the next Chisel bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor out prerequisite pieces from: #4699
I need to go muck with Layer Control to fix #4676 and want to work on the latest version of this.
Release Notes
Add ChiselSettings class for controlling Chiselsim simulations.