[chiselsim] Add CLI FSDB, VPD support, enable waves (VCD, too) #4797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82ecfed to
a9ab593
Compare
Fix a bug where modifications applied via command line arguments would not be reflected by ChiselSim. This was an issue of not using the modified settings. This additionally changes it so that the CLI modifications are always applied _last_. I.e., they could overwrite anything earlier or specified in Chisel. This seems to make the most sens as I would like to, as a user, be able to change the behavior of a test on the command line. Nothing else should override this. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Add an option to turn on waves at time zero via the runtime simulation settings. This option has no effect, yet. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Hook up a new option coming from svsim's simulation configuration that causes waveforms to be enabled at time zero. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Add a trait that can be used to allow for FSDB waveform support to be specified via a Scalatest option. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Add a trait that can be mixed into a test to give it access to compiling in VPD waveform support via a Scalatest option. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Change the three waveform CLI APIs (for FSDB, VCD, and VPD) to not just compile with waveform support, but to also enable waves. Now that enabling waves (via the Control API) requires compilation with waveform support, a command line option to enable the compilation with waves doesn't do much. These are additional _much_ better CLI APIs than before. This also matches the way that these were used internally. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
0be252d to
5f119d1
Compare
f71254e to
624fa12
Compare
Base automatically changed from
dev/seldridge/chiselsim-support-plusargs
to
main
March 15, 2025 21:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the existing VCD waveform CLI API to also enable waves. There was enough infrastructure there to do this and this is actually a way better API.
Add FSDB and VPD CLI emission. These require VCS and will throw an
IllegalArgumentExceptionif you try to use them with Verilator.Release Notes
-DemitVcd=1,-DemitVpd=1, and-DemitFsdb=1.