Skip to content

Conversation

seldridge
Copy link
Member

@seldridge seldridge commented Mar 14, 2025

Add the ability to set $value$plusarg and $test$plusargs directly from
ChiselSim simulate APIs. These can be specified using the lower level
options to the simulator or via the implicit common/backend-specific
options. However, this new API is the intended way that these should be
set by the user going forward.

Add the ability to pass plusargs to svsim simulations.

Note: there is some ugliness here in that simulation options are passed to functions that are doing "compilation". This is a software architecture problem in svsim as evidenced by backend compilation options including runtime options (for VCS). This all needs to be cleaned up separately.

Release Notes

Add support for Verilog $value$plusargs and $test$plusargs to svsim and ChiselSim.

@seldridge seldridge added the Feature New feature, will be included in release notes label Mar 14, 2025
@seldridge seldridge force-pushed the dev/seldridge/chiselsim-support-plusargs branch from 08d5f1d to 0be252d Compare March 15, 2025 00:23
@seldridge seldridge requested a review from jackkoenig March 15, 2025 00:23
@seldridge seldridge marked this pull request as ready for review March 15, 2025 00:23
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor suggestion

Add the ability to pass plusargs to svsim simulations.

Note: there is some ugliness here in that simulation options are passed to
functions that are doing "compilation".  This is a software architecture
problem in svsim as evidenced by backend compilation options including
runtime options (for VCS).  This all needs to be cleaned up separately.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Add the ability to set `$value$plusarg` and `$test$plusargs` directly from
ChiselSim simulate APIs.  These can be specified using the lower level
options to the simulator or via the implicit common/backend-specific
options.  However, this new API is the intended way that these should be
set by the user going forward.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
@seldridge seldridge force-pushed the dev/seldridge/chiselsim-support-plusargs branch from 0be252d to 5f119d1 Compare March 15, 2025 19:57
@seldridge seldridge merged commit 5f119d1 into main Mar 15, 2025
15 checks passed
@seldridge seldridge deleted the dev/seldridge/chiselsim-support-plusargs branch March 15, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants