[scalatest] Add HasCliSimulator #4776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new trait, `HasCliSimulator`, that builds on `HasConfigMap` to provide a standardized way to get a simulator that the user can choose at scalatest test time via a `-Dsimulator=<simulator-name>` argument. Note: this is difficult to test, however, I've tested it manually. Co-authored-by: Jack Koenig <koenig@sifive.com> Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new trait,
HasCliSimulator, that builds onHasConfigMapto provide a standardized way to get a simulator that the user can choose at scalatest test time via a-Dsimulator=<simulator-name>argument.Note: this is difficult to test, however, I've tested it manually.
CC: @andrew-gouldey-sifive: I'm planning to get this into the open source and then use it internally. We will customize the simulator used internally slightly for the different Verilator or VCS default options that we use.
Release Notes
Add
HasCliSimulatorwhich can be used, along withHasConfigMap, to allow for tests to choose their simulator at test time via a-Dcommand line option. This is added to avoid fragmentation of command line options around choosing which simulator to run.