[testing] Testing package w/ HasTestingDirectory #4750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new package, `chisel3.testing`, and move `simulator.HasTestingDirectory` and the scalatest implementation of it to the new package. This is done because the ability to get a testing directory is really a general property of "testing" and not "simulation". This also builds towards moving the FileCheck utility out of `ChiselSpec` (i.e., only being available for tests) and into a proper home in `testing`. It also makes sense for FileCheck to use the `HasTestingDirectory` type class as it has the same problem of needing to be given a "testing directory". Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
jackkoenig
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new package,
chisel3.testing, and movesimulator.HasTestingDirectoryand the scalatest implementation of it to the new package. This is done because the ability to get a testing directory is really a general property of "testing" and not "simulation".This also builds towards moving the FileCheck utility out of
ChiselSpec(i.e., only being available for tests) and into a proper home intesting. It also makes sense for FileCheck to use theHasTestingDirectorytype class as it has the same problem of needing to be given a "testing directory".