[chiselsim] Add FIRRTL macro control #4699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
commented
Feb 15, 2025
| layerControl: LayerControl.Type = LayerControl.EnableAll, | ||
| chiselSettings: ChiselSettings[T] = ChiselSettings.default[T], |
There was a problem hiding this comment.
Note: because the default factory is necessarily given a type parameter with a lower bound (A <: RawModule]), this necessitates giving it a type parameter on line 77 here. If I don't do this, this will infer to Nothing and everything blows up.
There may be a way to untangle this.
50f6ddf to
58a1586
Compare
This was referenced Feb 19, 2025
58a1586 to
bd1218d
Compare
Base automatically changed from
dev/seldridge/switch-to-ChiselSettings
to
main
February 19, 2025 19:55
bd1218d to
16ec7fe
Compare
Extend ChiselSettings with three macros which were currently being set by ChiselRunners: - ASSERT_VERBOSE_COND - PRINTF_COND - STOP_COND Make this work in such a way that the user can specify a function that will return the _signal_ that they want to use to set this macro in one of several predefined ways. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
16ec7fe to
ac56d63
Compare
jackkoenig
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change SimulatorAPI methods to use the ChiselSettings class instead of
directly communicating layerControl. This will enable us to lump together
more options that all are associated with Chisel/FIRRTL/the Verilog ABI.
Extend ChiselSettings with three macros which were currently being set by
ChiselRunners:
Make this work in such a way that the user can specify a function that
will return the signal that they want to use to set this macro in one of
several predefined ways.
This is working towards replacing this part of ChiselSpec: https://github.com/chipsalliance/chisel/blob/main/src/test/scala-2/chiselTests/ChiselSpec.scala#L60
Release Notes