Skip to content

Refine annotate and Targetable #4698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

Refine annotate and Targetable #4698

merged 1 commit into from
Feb 18, 2025

Conversation

jackkoenig
Copy link
Contributor

Some minor improvements to the user API for annotating with Targetable

  • Support annotating Seq[Targetable] and provide Targetable for AnyTargetable.
  • Add AnyTargetable.apply for simpler manual conversions.
  • Show tests annotating Seq[Targetable] and manual use of AnyTargetable.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • No Release Notes

Changes to unreleased API

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig
Refine annotate and Targetable
01d0080 
Some minor improvements to the user API for annotating with Targetable
* Support annotating Seq[Targetable] and provide Targetable for AnyTargetable.
* Add AnyTargetable.apply for simpler manual conversions.
* Show tests annotating Seq[Targetable] and manual use of AnyTargetable.
@jackkoenig jackkoenig added the No Release Notes Exclude from release notes, consider using Internal instead label Feb 14, 2025
@jackkoenig jackkoenig added this to the 6.x milestone Feb 14, 2025
@jackkoenig jackkoenig requested a review from seldridge February 14, 2025 23:25
@jackkoenig jackkoenig merged commit e20069e into main Feb 18, 2025
18 checks passed
@jackkoenig jackkoenig deleted the jackkoenig/improved-targetable branch February 18, 2025 19:30
@mergify mergify bot added the Backported This PR has been backported label Feb 18, 2025
chiselbot pushed a commit that referenced this pull request Feb 18, 2025
@jackkoenig @chiselbot
Refine annotate and Targetable (#4698)
d76190a 
Some minor improvements to the user API for annotating with Targetable
* Support annotating Seq[Targetable] and provide Targetable for AnyTargetable.
* Add AnyTargetable.apply for simpler manual conversions.
* Show tests annotating Seq[Targetable] and manual use of AnyTargetable.

(cherry picked from commit e20069e)
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 18, 2025

backport

✅ Backports have been created

@chiselbot chiselbot mentioned this pull request Feb 18, 2025
Merged
14 tasks
jackkoenig added a commit that referenced this pull request Mar 1, 2025
@jackkoenig
Refine annotate and Targetable (#4698)
decd7e3 
Some minor improvements to the user API for annotating with Targetable
* Support annotating Seq[Targetable] and provide Targetable for AnyTargetable.
* Add AnyTargetable.apply for simpler manual conversions.
* Show tests annotating Seq[Targetable] and manual use of AnyTargetable.

(cherry picked from commit e20069e)
chiselbot added a commit that referenced this pull request Mar 1, 2025
@chiselbot @jackkoenig
Refine annotate and Targetable (backport #4698) (#4703)
9d28ac6 
* Refine annotate and Targetable (#4698)

Some minor improvements to the user API for annotating with Targetable
* Support annotating Seq[Targetable] and provide Targetable for AnyTargetable.
* Add AnyTargetable.apply for simpler manual conversions.
* Show tests annotating Seq[Targetable] and manual use of AnyTargetable.

(cherry picked from commit e20069e)

* Run formatting

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge Awaiting requested review from seldridge

Assignees
No one assigned
Labels
Backported This PR has been backported No Release Notes Exclude from release notes, consider using Internal instead
Projects
None yet
Milestone
6.x
Development

Successfully merging this pull request may close these issues.
1 participant
@jackkoenig