[chiselsim] Add ChiselSim APIs #4685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two new traits: 1. chisel3.simulator.ChiselSim 2. chisel3.simulator.scalatest.ChiselSim They provide the same set of APIs (`PeekPokeAPI` and `SimulatorAPI`), but the latter is additionally specialized for better integration with Scalatest (and also requires integration with Scalatest via a self type). These are intended to be the main entrypoints for working with the platonic ideal of "ChiselSim" and are not supposed to be anything other than a collection of APIs. (Please don't add anything more to these and instead factor additional APIs into additions to their constituent traits.) Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
88894e5 to
3087402
Compare
|
After an offline discussion with @jackkoenig, I'm dropping this to only the trait-based APIs. We can add the object-based APIs later if desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two flavors of APIs for working with
ChiselSim. This provides both the "trait mix-in" pattern and the "wildcard object import" pattern.Release Notes
ChiselSimAPIs. This as the main entry points toChiselSimand should be used in favor of theEphemeralSimulator.