-
Notifications
You must be signed in to change notification settings - Fork 637
[Chiselsim] Add WithTestingDirectory #4669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a trait, `WithTestingDirectory`, that will automatically create a test directory structure based on Scalatest information. This provides a type class implementation of `HasTestingDirectory`, but with better Scalatest-specific directories as opposed to generic timestamp-based ones. This necessarily introduces a provided ("compile only" to Mill) dependency on Scalatest for Chisel. This prevents making all of Chisel pull in Scalatest and relies on the user to load it. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
jackkoenig
reviewed
Feb 7, 2025
src/test/scala/chiselTests/simulator/scalatest/WithTestingDirectorySpec.scala
Show resolved
Hide resolved
jackkoenig
reviewed
Feb 7, 2025
src/main/scala-2/chisel3/simulator/scalatest/WithTestingDirectory.scala
Outdated
Show resolved
Hide resolved
jackkoenig
reviewed
Feb 7, 2025
jackkoenig
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome, nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a trait,
WithTestingDirectory
, that will automatically create a test directory structure based on Scalatest information. This provides a type class implementation ofHasTestingDirectory
, but with better Scalatest-specific directories as opposed to generic timestamp-based ones.This necessarily introduces a provided ("compile only" to Mill) dependency on Scalatest for Chisel. This prevents making all of Chisel pull in Scalatest and relies on the user to load it.
E.g., the included test will create the following directory structure:
Release Notes
Add
WithTestingDirectory
Scalatest suite mix-in that automatically sets up a Scalatest-specific directory structure for your tests.