Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now depends on #4717.
Because views may not map 1-1 to FIRRTL targets and that annotations are so heavily exposed to the user (esp. via Stage/Phase), we have to generate a RenameMap for any views that are annotated. Previously, we couldn't know what views might be annotated (the
.toTarget
call is after Chisel elaboration) so we had to conservatively generate aRenameMap
for all views that don't map 1-1. This is ludicriously expensive.With #4643, we now require that annotations report what Data will be annotated up front, so now we only need to rename views that are actually annotated. Much more elegant and efficient at the cost of a minor API change.
I guess technically we shouldn't merge this until the deprecated APIs are removed... 🙈
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.