Add new InlineInstanceAllowDedup trait #4508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The InlineInstance trait can be attached to a module, to cause firtool to inline instance of that module. The inline annotation is tricky to wield because, if an inline module dedups with another module, we will inline all instances of both modules. To make InlineInstance easier to use, whenever we mark a module as inline, we also mark it as "no dedup". This of course does not work well when we have a module which we want to inline AND dedup. So, this PR adds a new InlineAllInstances trait which allows a module to be marked inline without blocking dedup.
This was referenced Mar 6, 2025
tymcauley
added a commit
to tymcauley/rocket-chip
that referenced
this pull request
Mar 9, 2025
The `ChiselAnnotation` API is going away in Chisel 7. Also in Chisel 7, this trait can be replaced by `chisel3.util.experimental.InlineInstanceAllowDedup`: chipsalliance/chisel#4508
tymcauley
added a commit
to tymcauley/rocket-chip
that referenced
this pull request
Mar 9, 2025
The `ChiselAnnotation` API is going away in Chisel 7. Also in Chisel 7, this trait can be replaced by `chisel3.util.experimental.InlineInstanceAllowDedup`: chipsalliance/chisel#4508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The InlineInstance trait can be attached to a module, to cause firtool to inline instance of that module. The inline annotation is tricky to wield because, if an inline module dedups with another module, we will inline all instances of both modules.
To make InlineInstance easier to use, whenever we mark a module as inline, we also mark it as "no dedup".
This of course does not work well when we have a module which we want to inline AND dedup. So, this PR adds a new InlineInstanceAllowDedup trait which allows a module to be marked inline without blocking dedup.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.