Skip to content

Conversation

unlsycn
Copy link
Contributor

@unlsycn unlsycn commented Oct 3, 2024

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

Release Notes

Add source locator for Sequence

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@sequencer sequencer added the Feature New feature, will be included in release notes label Oct 3, 2024
@sequencer sequencer changed the title fix: add SourceLocator for Sequence Add SourceLocator for Sequence Oct 3, 2024
@sequencer
Copy link
Member

This is not a fix bug a feature, please amend your commit.

Signed-off-by: unlsycn <unlsycn@unlsycn.com>
@unlsycn
Copy link
Contributor Author

unlsycn commented Oct 3, 2024

This is not a fix bug a feature, please amend your commit.

Done.

@jackkoenig jackkoenig merged commit feaf331 into chipsalliance:main Oct 4, 2024
15 checks passed
debs-sifive pushed a commit that referenced this pull request Oct 15, 2024
Signed-off-by: unlsycn <unlsycn@unlsycn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants