Skip to content

Conversation

unlsycn
Copy link
Contributor

@unlsycn unlsycn commented Nov 4, 2024

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@sequencer
Copy link
Member

Please add some test to this feature, and mdoc would better.

@jackkoenig jackkoenig added the Feature New feature, will be included in release notes label Nov 4, 2024
@unlsycn
Copy link
Contributor Author

unlsycn commented Nov 4, 2024

Here are some questions about the source locator in Auto Blackbox.
We can hope that the source locator of the definition of extmodule is the location that we instantiate.

@unlsycn unlsycn marked this pull request as draft November 11, 2024 05:18
@unlsycn unlsycn force-pushed the auto-blackbox branch 2 times, most recently from 813336e to 87de205 Compare November 12, 2024 05:34
@unlsycn unlsycn force-pushed the auto-blackbox branch 5 times, most recently from 52c4a30 to ce20586 Compare November 12, 2024 12:02
@unlsycn unlsycn marked this pull request as ready for review November 12, 2024 12:52
@unlsycn unlsycn requested a review from sequencer November 12, 2024 12:59
Copy link
Member

@sequencer sequencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick on the documentation, please fix.

Signed-off-by: unlsycn <unlsycn@unlsycn.com>
Signed-off-by: unlsycn <unlsycn@unlsycn.com>
Signed-off-by: unlsycn <unlsycn@unlsycn.com>
@sequencer sequencer added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Nov 12, 2024
@chiselbot chiselbot merged commit d660f47 into chipsalliance:main Nov 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature, will be included in release notes Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants