Skip to content

Conversation

jackkoenig
Copy link
Contributor

I also changed HasTarget to only wrap SramTarget rather than any NamedComponent which I explain in the comments:

This is only currently used for SRAM to hide the underlying Memory but still let users annotate it.
Rather than generalizing this, it's more likely that we'll just delete it (and the use in SRAM) in favor of Path Properties.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Feature New feature, will be included in release notes label Oct 18, 2024
@jackkoenig jackkoenig added this to the 6.x milestone Oct 18, 2024
@azidar
Copy link
Contributor

azidar commented Oct 18, 2024

The logic looks ok to me.

@jackkoenig jackkoenig merged commit a7a68e5 into main Oct 18, 2024
18 checks passed
@jackkoenig jackkoenig deleted the jackkoenig/hastarget-lookupable branch October 18, 2024 21:58
@mergify mergify bot added the Backported This PR has been backported label Oct 18, 2024
mergify bot pushed a commit that referenced this pull request Oct 18, 2024
jackkoenig added a commit that referenced this pull request Nov 26, 2024
chiselbot pushed a commit that referenced this pull request Nov 26, 2024
…4482)

* Implement Lookupable for HasTarget (used by SRAM) (#4481)

(cherry picked from commit a7a68e5)

* Fix for 6.x

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Feature New feature, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants