Fix missing string interpolators, add -Xlint:missing-interpolator #4471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeurbach
approved these changes
Oct 15, 2024
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
) (cherry picked from commit ca773c0) # Conflicts: # build.sc # core/src/main/scala/chisel3/Aggregate.scala # core/src/main/scala/chisel3/experimental/hierarchy/core/Hierarchy.scala # core/src/main/scala/chisel3/experimental/hierarchy/core/Instance.scala # src/main/scala/chisel3/aop/Select.scala
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
) (cherry picked from commit ca773c0) # Conflicts: # build.sc # core/src/main/scala/chisel3/Aggregate.scala # core/src/main/scala/chisel3/experimental/hierarchy/core/Hierarchy.scala # core/src/main/scala/chisel3/experimental/hierarchy/core/Instance.scala
This was referenced Oct 16, 2024
chiselbot
pushed a commit
that referenced
this pull request
Nov 25, 2024
…ckport #4471) (#4473) * Fix missing string interpolators, add -Xlint:missing-interpolator (#4471) (cherry picked from commit ca773c0) # Conflicts: # build.sc # core/src/main/scala/chisel3/Aggregate.scala # core/src/main/scala/chisel3/experimental/hierarchy/core/Hierarchy.scala # core/src/main/scala/chisel3/experimental/hierarchy/core/Instance.scala * Resolve backport conflicts --------- Co-authored-by: Jack Koenig <koenig@sifive.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hit an internal error and it isn't useful because of missing String interpolators. Fix that
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.